Conversation
This comment has been minimized.
This comment has been minimized.
|
should be good now for the PR build. |
|
only failed on 11.0 now. |
|
Build error: |
This is the first time I've built Haskell software on macos 11, and the problem seems to be https://gitlab.haskell.org/ghc/ghc/-/issues/18446, affecting all current GHC releases. How are other haskell packages in homebrew dealing with this I wonder ? Maybe they don't require system frameworks ? |
|
It seems like the options for updating (affected?) haskell apps in homebrew right now are:
|
|
Does the workaround work for you locally? One way to use it when installing formulae would be to declare it in a Also, if upstream already have fixes lined up for the next release, it might be better to just use their patches with existing formulae. Pinging @SMillerDev, who'll know better about whether a workaround is the right thing to do for Homebrew. |
|
I don't have big sur locally. Thanks for the info, I'll wait to hear from SMiller, but I am inclined to hope that a GHC update will be released and become available in homebrew soon enough. |
|
Whatever is an official patch from upstream we'd want to use. |
This seems to be affecting a number of other haskell-based builds too. But I suppose that shouldn't be surprising. See #65759, though I am essentially just repeating @simonmichael's comments there. |
|
This should hopefully be unblocked by #67284 |
|
Picked up your commits, squashed them and included them here: #67284 Hopefully, it fixes some build failures... |
|
Actually, you can add whatever fixes to |
|
Updated to use homebrew's latest ghc; CI is expected to fail for this push, but hopefully will succeed when it's combined with #67284. |
|
Thanks. I've added your commit to the ghc PR. |
6a961f4 to
08d3255
Compare
|
Switched back to cabal (temporarily ?) since stack + ghc 8.10.3 isn't working just now. |
|
Can you try replacing |
carlocab
left a comment
There was a problem hiding this comment.
Glad to see it's finally building. Just a few minor suggestions.
Update to hledger 1.20.1. Also, - use hledger-web's built-in tests - build with a newer stackage snapshot - build with the latest homebrew ghc, 8.10.3 - add some improvements suggested by reviewers
carlocab
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @simonmichael!
|
🤖 A scheduled task has triggered a merge. |
|
|
|
Thank you! |
Update to hledger 1.20. Also,